Skip to content

添加应用重新加载功能 #4513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

添加应用重新加载功能 #4513

wants to merge 7 commits into from

Conversation

@rootwhois
Copy link
Contributor

No description provided.

@Glavo
Copy link
Member

Glavo commented Sep 19, 2025 •
edited
Loading

看起来好像和 #4468 部分重复

@rootwhois
Copy link
Contributor Author

#4468

本pr的重载功能逻辑：当需要重启生效的配置被修改（目前看到的有关闭动画、抗锯齿、语言切换选项）的时候，在标题栏右侧出现重载按钮，点击进行重载。后续有类似的功能需要实现，添加Property对应的Listener即可。

                config().localizationProperty().addListener(restartButtonListener);

@burningtnt burningtnt mentioned this pull request Sep 19, 2025
Closed
@hmr-BH hmr-BH mentioned this pull request Sep 29, 2025
Closed
3gf8jv4dv
3gf8jv4dv reviewed Oct 3, 2025
View reviewed changes
Copy link
Contributor

@3gf8jv4dv 3gf8jv4dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我测试了一下。

  • 语言重载目前没看到问题。
  • 抗锯齿重载我目前无法给出结论。
  • 关闭动画重载没有效果。

Glavo
Glavo reviewed Oct 19, 2025
View reviewed changes
Copy link
Member

@Glavo Glavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我很怀疑这个“重新加载”功能是否有意义。

需要重新启动才能生效的选项大部分是因为必须在 JavaFX 初始化之前才能应用设置，运行时重新加载不会有任何效果。

HMCL/src/main/java/org/jackhuang/hmcl/ui/Controllers.java
private Controllers() {
}

private static void setupFontAntialiasing() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

重载该选项没有意义，该选项只有在 JavaFX 界面显示前生效。

@burningtnt
Copy link
Member

怀疑此功能的意义。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Glavo Glavo Glavo left review comments

+1 more reviewer

@3gf8jv4dv 3gf8jv4dv 3gf8jv4dv left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rootwhois @Glavo @burningtnt @3gf8jv4dv